Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly report errors for http status >= 400 #1498

Merged
merged 1 commit into from
Oct 12, 2022
Merged

properly report errors for http status >= 400 #1498

merged 1 commit into from
Oct 12, 2022

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Oct 12, 2022

No description provided.

@evgeni evgeni linked an issue Oct 12, 2022 that may be closed by this pull request
redhat_manifest does not properly report wrong username/password #1497
Closed
@evgeni
Copy link
Member Author

evgeni commented Oct 12, 2022

FWIW, this is a change in ansible-core 2.13 that made resp is None not catch the error anymore.

See https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/porting_guides/porting_guide_core_2.13.rst#breaking-changes

@evgeni evgeni merged commit 1495e93 into theforeman:develop Oct 12, 2022
@evgeni evgeni deleted the manifest-error branch October 12, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redhat_manifest does not properly report wrong username/password
2 participants
@evgeni @mdellweg