Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role for managing hostgroups #1116

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Add role for managing hostgroups #1116

merged 1 commit into from
Apr 7, 2021

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Dec 22, 2020

Putting into draft initially as I want to work on a few better examples. Ideas welcome on what we can show here.

evgeni
evgeni reviewed Dec 23, 2020
View reviewed changes
roles/hostgroups/README.md Outdated Show resolved Hide resolved
evgeni
evgeni reviewed Dec 23, 2020
View reviewed changes
roles/hostgroups/README.md Outdated Show resolved Hide resolved
evgeni
evgeni reviewed Dec 23, 2020
View reviewed changes
roles/hostgroups/README.md Outdated Show resolved Hide resolved
@evgeni
Copy link
Member

evgeni commented Dec 23, 2020

few comments, but no good ideas about more examples

@ehelms ehelms force-pushed the hostgroups-role branch 2 times, most recently from 1b27f97 to f18eee3 Compare March 10, 2021 15:57
@ehelms ehelms marked this pull request as ready for review March 10, 2021 15:58
@ehelms ehelms requested a review from evgeni March 16, 2021 12:16
@evgeni evgeni mentioned this pull request Mar 16, 2021
Merged
wbclark
wbclark reviewed Mar 31, 2021
View reviewed changes
roles/hostgroups/README.md Outdated Show resolved Hide resolved
@ehelms ehelms force-pushed the hostgroups-role branch from d94e8b0 to 465a306 Compare April 6, 2021 17:59
evgeni
evgeni approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nit on the test, but nothing major/blocking

tests/test_playbooks/hostgroups_role.yml Outdated Show resolved Hide resolved
tests/test_playbooks/hostgroups_role.yml Outdated Show resolved Hide resolved
@ehelms ehelms force-pushed the hostgroups-role branch from 465a306 to 61e75c2 Compare April 7, 2021 11:57
@evgeni
Copy link
Member

evgeni commented Apr 7, 2021

aaah, changelog entry please XD

@ehelms ehelms force-pushed the hostgroups-role branch from 61e75c2 to e433407 Compare April 7, 2021 12:49
@ehelms
Copy link
Member Author

ehelms commented Apr 7, 2021

Added

@evgeni evgeni merged commit fd77093 into theforeman:develop Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbclark wbclark wbclark left review comments

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
enhancement triaged waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehelms @evgeni @wbclark