compose inventory_hostname #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Nov 27, 2020
| for host in self._get_hosts(): | ||
| if host.get('name'): |
There was a problem hiding this comment.
while this looks like a big change in the diff, it's actually just mostly re-indenting the code
There was a problem hiding this comment.
took me a while to comprehend that ;)
|
this is inspired by the vmware inventory, which supports similar composition |
|
fwiw lgtm |
nesanton
reviewed
Nov 27, 2020
| user: ansibleinventory | ||
| password: changeme | ||
| hostnames: | ||
| - name.split('.')[0] |
There was a problem hiding this comment.
Never seen companies putting dots in shortnames. Oh wait ...
nesanton
approved these changes
Nov 27, 2020
bb357f2 to
5195f53
Compare
5195f53 to
568cc01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1070