Skip to content

Commit

Permalink
clarify *all* modules can leak sensitive data, not only compute_resource
Browse files Browse the repository at this point in the history
Fixes: #1006
  • Loading branch information
evgeni authored and ehelms committed Oct 7, 2020
1 parent 30777fd commit c2ec6d2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ Starting with Ansible 2.7, Ansible only supports Python 2.7 and 3.5 (and higher)
* Some modules, e.g. `repository_sync` and `content_view_version`, trigger long running tasks on the server side. It might be beneficial to your playbook to wait for their completion in an asynchronous manner.
As Ansible has facilities to do so, the modules will wait unconditionally. See the [Ansible documentation](https://docs.ansible.com/ansible/latest/user_guide/playbooks_async.html) for putting tasks in the background.

* `compute_resource` can leak sensitive data if used within a loop. According to [Ansible documentation](https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html), using loop over Ansible resources can leak sensitive data. You can prevent this by using `no_log: yes` on the task.
* According to [Ansible documentation](https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html), using loop over Ansible resources can leak sensitive data. This applies to all modules, but especially those which require more secrets than the API credentials (`auth_source_ldap`, `compute_resource`, `host`, `hostgroup`, `http_proxy`, `image`, `repository`, `scc_account`, `user`). You can prevent this by using `no_log: yes` on the task.

eg:
```yaml
- name: Create compute resources
compute_resource:
theforeman.foreman.compute_resource:
server_url: https://foreman.example.com
username: admin
password: changeme
Expand Down

0 comments on commit c2ec6d2

Please sign in to comment.