Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InnerResultIterator: Improve count() performance of non-executed query #156

Merged
merged 2 commits into from
Jul 31, 2019
Merged

InnerResultIterator: Improve count() performance of non-executed query #156

merged 2 commits into from
Jul 31, 2019

Conversation

homersimpsons
Copy link
Collaborator

Previously this would have execute the query under MySQL, on large result set the executed query could have slow the application

@homersimpsons homersimpsons requested a review from moufmouf July 31, 2019 15:05
@coveralls
Copy link

coveralls commented Jul 31, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 97.429% when pulling 65f0e4b on homersimpsons:fix/inner-result-iterator-count-performance into 65e5feb on thecodingmachine:master.

moufmouf
moufmouf approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@moufmouf moufmouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% test coverage on InnerResultIterator!
💯

@moufmouf moufmouf merged commit b5ff431 into thecodingmachine:master Jul 31, 2019
@moufmouf moufmouf added this to the 5.1 milestone Aug 2, 2019
@homersimpsons homersimpsons deleted the fix/inner-result-iterator-count-performance branch August 10, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moufmouf moufmouf moufmouf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@homersimpsons @coveralls @moufmouf