Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite Pk - getById #153

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Composite Pk - getById #153

merged 2 commits into from
Jul 19, 2019
+67 −26

Conversation

homersimpsons
Copy link
Collaborator

Create a getById method for composite primary key

Note: If one of the primary key columns is part of a foreign key, an id (not an object) is still needed as it's a getById and not find method

Closes #100

@homersimpsons homersimpsons force-pushed the feature/composite-pk-get-by-id branch from 6c9ab06 to 50aad9f Compare July 19, 2019 14:02
@coveralls
Copy link

coveralls commented Jul 19, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 97.238% when pulling e0004d9 on feature/composite-pk-get-by-id into 906daf1 on master.

@moufmouf moufmouf merged commit 3affca3 into master Jul 19, 2019
@moufmouf moufmouf deleted the feature/composite-pk-get-by-id branch July 19, 2019 14:46
@homersimpsons homersimpsons changed the title Composite Pk - getById: Add Tests Composite Pk - getById Jul 19, 2019
@moufmouf moufmouf added this to the 5.1 milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

No findByXXX on primary keys with multiple columns
3 participants
@homersimpsons @coveralls @moufmouf