Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to give a null parameter if the column of type resource is nullable #137

Merged
merged 4 commits into from
Jun 22, 2019

Conversation

TheoBiron
Copy link
Contributor

Previously : the setter of a resource typed column wouldn't accept null parameter, even if the column was nullable

Unverified

This user has not yet uploaded their public signing key.
…source is nullable
@coveralls
Copy link

coveralls commented May 20, 2019

Coverage Status

Coverage increased (+0.004%) to 97.187% when pulling ae47a0d on TheoBiron:setter_resource_null into 1b9acd0 on thecodingmachine:master.

@moufmouf
Copy link
Member

We need to change the unit tests to test these changes.
We should create a nullable BLOB in the test model and check the method signature.

Unverified

This user has not yet uploaded their public signing key.
…_resource_null

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@moufmouf moufmouf merged commit 4573dd7 into thecodingmachine:master Jun 22, 2019
@moufmouf
Copy link
Member

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants