Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] use ProgressBar rather than log spam #530

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[cli] use ProgressBar rather than log spam #530

merged 1 commit into from
Jan 31, 2025

Conversation

shish
Copy link
Collaborator

@shish shish commented Jan 30, 2025

Before: 3400 lines

$ ./.devcontainer/build.sh
[...]
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-commit.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-connect.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-delete-user.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-drop-db.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-free-event-handler.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-free-query.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-free-result.xml
[...]

After: 1 line in interactive mode, ~10 lines in CI mode

$ ./.devcontainer/build.sh
    1/3463 [>---------------------------] apache
  347/3463 [==>-------------------------] datetime
  693/3463 [=====>----------------------] fdf
 1039/3463 [========>-------------------] ibase
 1386/3463 [===========>----------------] info
 1732/3463 [==============>-------------] mysql
 2078/3463 [================>-----------] pgsql
 2425/3463 [===================>--------] snmp
 2771/3463 [======================>-----] stream
 3117/3463 [=========================>--] trader
 3463/3463 [============================] zookeeper

Before: 3400 lines
```
$ ./.devcontainer/build.sh
[...]
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-commit.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-connect.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-delete-user.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-drop-db.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-free-event-handler.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-free-query.xml
Loading /app/generator/src/../doc/doc-en/en/reference/ibase/functions/ibase-free-result.xml
[...]
```

After: 1 line in interactive mode, ~10 lines in CI mode
```
$ ./.devcontainer/build.sh
    1/3463 [>---------------------------] apache
  347/3463 [==>-------------------------] datetime
  693/3463 [=====>----------------------] fdf
 1039/3463 [========>-------------------] ibase
 1386/3463 [===========>----------------] info
 1732/3463 [==============>-------------] mysql
 2078/3463 [================>-----------] pgsql
 2425/3463 [===================>--------] snmp
 2771/3463 [======================>-----] stream
 3117/3463 [=========================>--] trader
 3463/3463 [============================] zookeeper
```
@shish shish merged commit e8fb5b0 into master Jan 31, 2025
23 checks passed
@shish shish deleted the pr530 branch January 31, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants