Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support union type from php documentation #506

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Dec 16, 2024

resolves #504

This PR adds support for union types from the PHP documentation. They are defined as followed:

<methodsynopsis>
   <type class="union"><type>int</type><type>false</type></type>
   ...
</methodsynopsis>

Before, when a function was defined with this union type notation and it hasn't been corrected by PHPStan (function map), the return has been determined as void. This PR now determines those union type correctly. Several function are affected as you can see in the diff.

@shish
Copy link
Collaborator

shish commented Dec 17, 2024

That looks great, thank you :D

@shish shish merged commit f98860e into thecodingmachine:master Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generated openssl functions are broken
2 participants