Meta campaign page for regular giving #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdsl
commented
Jan 10, 2025
| [campaignTitle]="campaign.title" | ||
| [donateButtonUrl]="'/regular-giving/' + campaign.id" | ||
| [donateButtonLabel]="'Donate monthly'" | ||
| [moreInfoButtonUrl]="'/charity/' + campaign.charity.id" |
There was a problem hiding this comment.
Linking to the charity page may not be ideal as that page doesn't actually show any details of the charity at the moment, beyond their name and the list of campaigns they have with BG, but it may be the best option right now as the campaign page does not currently support regular giving campaigns (which might be something to fix).
We could also link to the charity's website. That's not available in the CampaignSummary type in FE but I think it is actually available at runtime when the data is sent via our CampaignSearchServiceModel in SF.
b45f412 to
3b373dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a few adjustments to the existing meta-campaign page for the regular giving case. Specifically removing the ticker, removing the match Funds Remaining indication on each card, changing "Donate now" to "Donate monthly", and changing the "find out more" link target.
This is how it looks with our test campaign. (I added a banner from unsplash & a definition from OED):
I think as it doesn't have those changes we'll also need to either exclude regular giving campaigns from the general explore page, or (IMHO less likely what we want) allow that page to show a mix of regular giving and ad-hoc giving campaigns.