main <- develop #1365
Merged
main <- develop #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev <- Main
Misc accessibility & UX fixes
Including Angular-downstream security patches
Make it clearer what they do; reduce type workarounds
DON-906 refactors + lib patch
…we may email them marketing messages
* Use the new design; retire the old campaign-card * Sort with newest (last ending) campaign first
For definitely-closed campaigns, go back from /donate/... to info. Also fix an error from undefined `this.donationStartForm` when the template conditions mean none is rendered and there is no such ViewChild
For now, introduces a quick banner on *all* closed campaigns saying that there *may* be others to explore
It was previously being lost under the reserved funds banner on desktop, making all sub-items unreachable
…dType` This should avoid the donate form breaking in edge cases like donors who started one donation recently, then later topped up with new funds
…ing with donor funds can fail
… on transfer funds
…nsfer-funds DON-898: Ask donation funds users for permission instead of assuming …
DON-902 – fix submenu not usable
…aign-direct-links BG2-2385 – tell donors & stop donations when we know a campaign isn't working
Co-authored-by: Barney Laurance <barney@thebiggive.org.uk>
Co-authored-by: Barney Laurance <barney@thebiggive.org.uk>
DON-820 – avoid & better report errors paying with donation funds
* ask Identity to return any existing tip balances awaiting bank transfer funding * if present in GBP, acknowledge any existing tip * and don't prompt for another, including the Gift Aid form group
…s-ux DON-472 help donors landing on old campaign pages find new ones
Improve how we pass `withTipBalances` to ID `get()` Co-authored-by: Barney Laurance <barney@thebiggive.org.uk>
….component.ts Update a missed `get()` call
…-for-pending-tips DON-596 – transfer funds tip handling
… 2023-10-31T23:00:00+00:00
DON-897, DON-915
DON-889 – enable skip link everywhere
Ensure top child campaigns aren't server-cached in memory in a way we didn't anticipate.
DON-773 - meta-campaign recent children tweak
* set tip numbers to 0 explicitly as an existing tip's detected * add an extra check to prevent creating another tip if form data somehow gets out of sync
Co-authored-by: Barney Laurance <barney@thebiggive.org.uk>
DON-596 - fix logic when a tip is pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.