Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formfield_for_dbfield signature #248

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

frnhr
Copy link
Contributor

@frnhr frnhr commented Apr 17, 2024

The signature of the overwriting method differs slightly from the overwritten method: https://github.com/django/django/blob/main/django/contrib/admin/options.py#L160

This causes an issue when the method is called with self.formfield_for_dbfield(db_field, request, **kwargs) (unexpected position argument).

@fdintino fdintino merged commit 0b2bc4f into theatlantic:master Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants