feat: support for LFS 0.7F #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
… they probably should've been from the start
de3063a to
fe98dd5
Compare
mkapal
reviewed
Jul 29, 2024
| } | ||
|
|
||
| impl Ipb { | ||
| /// Returns `true` if a Vehicle is contained in this packet |
There was a problem hiding this comment.
The comments in this packet definition still refer to "vehicle" and "mods", that looks like an oversight after a copy&paste.
mkapal
reviewed
Jul 29, 2024
| @@ -278,6 +278,10 @@ pub enum Packet { | |||
| #[brw(magic = 66u8)] | |||
| Plh(Plh), | |||
|
|
|||
| /// Both - Set/receive player handicap | |||
|
Doh goes to show I shouldn’t try and do this when I’m tired! Thanks Martin, I’ll get it sorted sometime today. I was going to cut a release so good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for LFS 0.7F, also mark all enums as non-exhaustive (as they probably should've been from the start)