Remove aria-hidden=true with noIsolation behavior #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior adds aria-hidden attribute throughout the DOM with
noIsolation === true
by callinghideOthers(refs, document.body, undefined)
.This makes introducing the library into a codebase with existing UI testing extremely challenging, as many testing frameworks ignore subtrees with
aria-hidden="true"
, meaning as soon as react-focus-on is used, many UI tests may go red. I made this in hopes of removing that barrier to entry.