Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SP-111 v2 #2047

Merged
merged 4 commits into from
Oct 29, 2023
Merged

Add support for SP-111 v2 #2047

merged 4 commits into from
Oct 29, 2023

Conversation

thompson-ele
Copy link
Contributor

Adds support for SP-111 v2 PCB. This version of the PCB has three RGB indicator LEDs which we would like to be controlled via the VIA v3 protocol.

Description

qmk/qmk_firmware#21652

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if intentional but you do not have the rgb matrix menus to change the animation (but you only have 3 rgb leds)

v3/viktus/sp111/sp111_v2.json Outdated Show resolved Hide resolved
@thompson-ele
Copy link
Contributor Author

Not sure if intentional but you do not have the rgb matrix menus to change the animation (but you only have 3 rgb leds)

Yeah the intention is 3 RGB LEDs that are used as indicator LEDs so no animations, just wanted them to be able to manage the colors independently. We will pray for a speedy addition to QMK core bc it's kind of disappointing not being able to use what is one of the big benefits of VIA v3 :(

@Xelus22 Xelus22 merged commit a1e0006 into the-via:master Oct 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants