Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mokey12x2 #1898

Closed
wants to merge 12 commits into from
Closed

Add mokey12x2 #1898

wants to merge 12 commits into from

Conversation

rhmokey
Copy link
Contributor

@rhmokey rhmokey commented Jun 13, 2023

Description

Add mokey12x2

QMK Pull Request

qmk/qmk_firmware#20702

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Jun 18, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert to v3. We are no longer accepting V2 legacy definitions.
Furthermore, V2 defintions wouldn't work with latest QMK firmware anyway.

https://www.caniusevia.com/docs/v3_changes

Xelus22
Xelus22 requested changes Jun 18, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires to be moved from src/ folder to v3 folder for v3 definitions.

@rhmokey
Copy link
Contributor Author

rhmokey commented Jun 18, 2023

Requires to be moved from src/ folder to v3 folder for v3 definitions.

Do I need to put it in the V3 folder?

@rhmokey rhmokey closed this Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhmokey @Xelus22