Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incorrect json for Blueberry #1868

Merged
merged 1 commit into from
May 21, 2023
Merged

Conversation

Cipulot
Copy link
Collaborator

@Cipulot Cipulot commented May 18, 2023

Fix of the json merged in the PR #1773 .

Description

After testing with the PCB some issues were found. In accordance with the dev I proceeded to address these issues on behalf of the original PR pusher, @ToffeeStudio .

This PR addresses the following issues:

  • incorrect rendering of the blocker
  • incorrect bottom row
  • incorrect ISO cluster row/col assignment

QMK Pull Request

qmk/qmk_firmware#19915

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22 Xelus22 merged commit 00e5c29 into the-via:master May 21, 2023
@Cipulot Cipulot deleted the fix_blueberry branch May 21, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants