Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manibus VIA Support #1837

Merged
merged 15 commits into from
May 21, 2023
Merged

Conversation

SamuraiKek
Copy link
Contributor

Description

Add Manibus keyboard VIA support

QMK Pull Request

qmk/qmk_firmware#20497

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented May 2, 2023

Please remove the V2 definition (under src/ folder) as that is only for legacy boards.

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? the mods/accents? it doesn't seem right to me. just making sure
image

@SamuraiKek
Copy link
Contributor Author

Is this correct? the mods/accents? it doesn't seem right to me. just making sure image

Sorry for the late reply, I kinda forgot this PR was still open. Yes, the mods/accents are correct. I've also removed the v2 definition.

@SamuraiKek SamuraiKek requested a review from Xelus22 May 18, 2023 13:39
@Xelus22 Xelus22 merged commit 3b6fa8c into the-via:master May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants