Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Adding OSAv2 Support #1787

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

blindassassin111
Copy link
Contributor

Description

Adding support for the OSAv2 MX PCB.

QMK Pull Request

qmk/qmk_firmware#20166

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented Mar 24, 2023

I see that in your QMK firmware PR that you only have 3 animations enabled. In QMK with the default ones, we assume you have all the animations enabled in QMK. You can customise it if u want. Just a heads up.

https://github.com/the-via/reader/tree/master/src/common-menus

@blindassassin111
Copy link
Contributor Author

I see that in your QMK firmware PR that you only have 3 animations enabled. In QMK with the default ones, we assume you have all the animations enabled in QMK. You can customise it if u want. Just a heads up.

https://github.com/the-via/reader/tree/master/src/common-menus

I was only enabling the ones most likely to be used to not bloat the firmware too much. Is this a change I should make or is it fine as is?

@Xelus22
Copy link
Collaborator

Xelus22 commented Mar 24, 2023

I was only enabling the ones most likely to be used to not bloat the firmware too much. Is this a change I should make or is it fine as is?

It will look seem broken and the names wont line-up in VIA. If you have the RGB animations enabled and just have enough space thats fine to keep them enabled in the QMK Firmware side.

Or if you still only want those 3, you should have the custom UI and not the predefined "qmk_rgblight" in the menus: and replace with ones that you have removed out. From https://github.com/the-via/reader/blob/master/src/common-menus/qmk_rgblight.ts

@Xelus22 Xelus22 merged commit b0db6e6 into the-via:master Mar 24, 2023
@blindassassin111 blindassassin111 deleted the osav2 branch March 24, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants