Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Degenpad #1692

Merged
merged 3 commits into from
Feb 19, 2023
Merged

Add Degenpad #1692

merged 3 commits into from
Feb 19, 2023

Conversation

ThePanduuh
Copy link
Contributor

@ThePanduuh ThePanduuh commented Feb 12, 2023 •
edited by yiancar
Loading

Description

QMK Pull Request

qmk/qmk_firmware#19812

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@ThePanduuh ThePanduuh marked this pull request as ready for review February 12, 2023 01:14
@ThePanduuh ThePanduuh marked this pull request as draft February 12, 2023 01:14
MaiTheSan
MaiTheSan suggested changes Feb 14, 2023
View reviewed changes
@ThePanduuh
Copy link
Contributor Author

Sorry about that. I must have done the V3 conversion in the V2 folder and was using that to test online. And then what was in the V3 folder was the beginning, prior to receipt of PCBs in my hands.
Hopefully it's all good now.

@ThePanduuh ThePanduuh marked this pull request as ready for review February 18, 2023 17:33
@ThePanduuh
Copy link
Contributor Author

Merged into QMK :)

@yiancar
Copy link
Collaborator

yiancar commented Feb 19, 2023

Cheers thanks!

@yiancar yiancar merged commit 12f95e8 into the-via:master Feb 19, 2023
j4ckofalltrades pushed a commit to j4ckofalltrades/via-keyboards that referenced this pull request Feb 20, 2023
@ThePanduuh @j4ckofalltrades
Add Degenpad (the-via#1692)
8fe606c 
* Create degenpad.json

* Update to V3

* Corrected V2/V3 version files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaiTheSan MaiTheSan MaiTheSan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThePanduuh @yiancar @MaiTheSan