Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keychron Q3 #1526

Merged
merged 2 commits into from
Nov 19, 2022
Merged

Add Keychron Q3 #1526

merged 2 commits into from
Nov 19, 2022

Conversation

KeychronMacro
Copy link
Contributor

Add VIA support for Keychron Q3
Thank you

Description

  • Add VIA JSONs for Keychron Q3
    Add ANSI, ISO and JIS versions, including encoder variants
    Add encoder ID (e0) as the center label for encoder keys to support encoder mapping
  • Correct cycle effect names to proper spelling for Q boards

QMK Pull Request

qmk/qmk_firmware#16912

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

src/keychron/q3/ansi.json Outdated Show resolved Hide resolved
@Xelus22
Copy link
Collaborator

Xelus22 commented Nov 19, 2022

LGTM. Thanks!

@Xelus22 Xelus22 merged commit fe5e3ff into the-via:master Nov 19, 2022
@KeychronMacro KeychronMacro deleted the keychron-q3 branch December 13, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants