-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Keychron Q0, Q1v1 and Q2 #1525
Conversation
- Rename `CYCKE` in `CYCKL_SPIRAL` effect name to `CYCLE` for correct spelling. - Add encoder key to knob variants of Q1v1 and Q2 to replace the two extra keys that were used with the `action_exec` hack that previously enabled encoders.
Simplified the names of `title:` and `shortName:` of custom keycodes.
Add 8 new effects to Q1v1 and Q2 (previously 14. Now 22)
Updated Checklist |
To keep the PR requests clean, we will close this request for now. Please leave a comment when QMK has been merged and we will open it again:) |
The 2nd PR from the "QMK Pull Request" (Update Q1 and Q2 for keychron #18713) has just been merged into the QMK repo 8 hours ago as of this msg. |
@yiancar can you reopen this pull? |
@adophoxia Hi, could you please kindly assist me to rename the keyboard name with "ansi, ansi_encoder, iso and iso_encoder" instead of "rev_0100, rev_0111, rev_0112 and rev_0113" according to the PR#18713 respectively. |
@lalalademaxiya1, they are already renamed to their new respective names. It's just that this PR doesn't reflect that if it's closed, so unless someone reopens it (or if I make a new one since the Q1v2 if being added to |
这是来自QQ邮箱的自动回复邮件。
您好,我已收到你的信件,我将尽快查阅,感谢你。
|
@adophoxia Thanks for your work, I pulled a new PR(#1620) and welcome to check it at your convenience. |
Description
Q series
CYCKE
inCYCKL_SPIRAL
effect name toCYCLE
for correct spelling.Q1v1 and Q2
action_exec
hack that previously enabled encoders.QMK Pull Request
Checklist
0xFEED