Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Keychron Q0, Q1v1 and Q2 #1525

Closed
wants to merge 3 commits into from

Conversation

adophoxia
Copy link
Contributor

@adophoxia adophoxia commented Nov 14, 2022

Description

Q series

  • Rename CYCKE in CYCKL_SPIRAL effect name to CYCLE for correct spelling.
  • Add 8 new effects to Q0, Q1v1 and Q2 (previously 14. Now 22)

Q1v1 and Q2

  • Add encoder key to knob variants of Q1v1 and Q2 to replace the two extra keys that were used with the action_exec hack that previously enabled encoders.

QMK Pull Request

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

- Rename `CYCKE` in `CYCKL_SPIRAL` effect name to `CYCLE` for correct spelling.
- Add encoder key to knob variants of Q1v1 and Q2 to replace the two extra keys that were used with the `action_exec` hack that previously enabled encoders.
Simplified the names of `title:` and `shortName:` of custom keycodes.
Add 8 new effects to Q1v1 and Q2 (previously 14. Now 22)
@Xelus22 Xelus22 added the pending QMK merge Waiting for merge into QMK master label Nov 19, 2022
@adophoxia
Copy link
Contributor Author

Updated Checklist

@yiancar
Copy link
Collaborator

yiancar commented Dec 6, 2022

To keep the PR requests clean, we will close this request for now. Please leave a comment when QMK has been merged and we will open it again:)
This PR is still not in: qmk/qmk_firmware#18713

@yiancar yiancar closed this Dec 6, 2022
@adophoxia
Copy link
Contributor Author

The 2nd PR from the "QMK Pull Request" (Update Q1 and Q2 for keychron #18713) has just been merged into the QMK repo 8 hours ago as of this msg.

@adophoxia
Copy link
Contributor Author

Forgot to @ for when #18713 was merged, but it's now been merged @yiancar.

@keychron-dev
Copy link

@yiancar can you reopen this pull?
as mentioned above. The 2nd PR from the "QMK Pull Request" (qmk/qmk_firmware#19048) has just been merged into the QMK repo.

@KeychronMacro
Copy link
Contributor

KeychronMacro commented Jan 6, 2023

@adophoxia Hi, could you please kindly assist me to rename the keyboard name with "ansi, ansi_encoder, iso and iso_encoder" instead of "rev_0100, rev_0111, rev_0112 and rev_0113" according to the PR#18713 respectively.

@adophoxia
Copy link
Contributor Author

adophoxia commented Jan 6, 2023

@lalalademaxiya1, they are already renamed to their new respective names. It's just that this PR doesn't reflect that if it's closed, so unless someone reopens it (or if I make a new one since the Q1v2 if being added to qmk:master), it'll be like as if I did nothing.

@LALALAdemaxiya
Copy link

LALALAdemaxiya commented Jan 6, 2023 via email

@KeychronMacro
Copy link
Contributor

@adophoxia Thanks for your work, I pulled a new PR(#1620) and welcome to check it at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants