Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Calice #1518

Merged
merged 3 commits into from
Nov 13, 2022
Merged

add Calice #1518

merged 3 commits into from
Nov 13, 2022

Conversation

Jels02
Copy link
Contributor

@Jels02 Jels02 commented Nov 9, 2022

Description

Add support for Calice

QMK Pull Request

qmk/qmk_firmware#17929

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Nov 13, 2022
View reviewed changes
@Jels02 @Xelus22
Update src/qwertlekeys/calice.json
1c1f184 
Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>
@Jels02 Jels02 requested a review from Xelus22 November 13, 2022 12:15
@Xelus22
Copy link
Collaborator

Xelus22 commented Nov 13, 2022

LGTM. Thanks!

@Xelus22 Xelus22 merged commit 9f5d5c3 into the-via:master Nov 13, 2022
@Jels02 Jels02 deleted the calice branch November 13, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jels02 @Xelus22