Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dactyl manuform 3x5_3 #1375

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Add dactyl manuform 3x5_3 #1375

merged 3 commits into from
Aug 23, 2022

Conversation

romeobalta
Copy link
Contributor

Description

Added the v3 .json for the handwired 3x5_3 dactyl manuform.

QMK Pull Request

qmk/qmk_firmware#16238

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@yiancar
Copy link
Collaborator

yiancar commented Aug 19, 2022

v3 jsons are not allowed at the time until the final update to the v3 protocol is pushed.
Either convert it to v2 or close this PR please:)

@romeobalta
Copy link
Contributor Author

@yiancar My bad. I've converted it to v2.

@yiancar
Copy link
Collaborator

yiancar commented Aug 23, 2022

Cheers thanks

@yiancar yiancar merged commit 8ce41fa into the-via:master Aug 23, 2022
mattchan pushed a commit to mattchan/keyboards that referenced this pull request Aug 31, 2022
* added dactyl manuform 3x5_3

* v3 to v2

* added missing prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants