Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lang with api queries #118

Merged
merged 9 commits into from
Jul 7, 2022
Merged

Use lang with api queries #118

merged 9 commits into from
Jul 7, 2022

Conversation

GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented Jul 7, 2022

Use lang with api queries

This pull request does the following:

  • Uses the new items query over the deprecated itemsByType query
  • Adds the lang: attribute to the items API query based on the user's selected language
  • Adds a helper function for getting two digit lang codes -> src/modules/lang-helpers.js
  • Adds a prebuild script that creates trader icons from their respective translation

resolves: #107

Example 📸

image

@GrantBirki GrantBirki added enhancement New feature or request language Changes related to wording on the site or translations labels Jul 7, 2022
@GrantBirki GrantBirki requested a review from a team as a code owner July 7, 2022 16:41
@GrantBirki
Copy link
Member Author

.deploy to development

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Deployment Triggered

GrantBirki, started a branch deployment 🚀

  • Branch: use-lang-with-api-queries
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to development July 7, 2022 16:48 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: use-lang-with-api-queries

Successfully deployed branch use-lang-with-api-queries

Actor: GrantBirki, Action: issue_comment, Workflow: branch-deploy

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 7, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 620906b
Status: ✅  Deploy successful!
Preview URL: https://193e4d4f.tarkov-dev.pages.dev

View logs

remove unnecessary `type: any` from query.
@GrantBirki
Copy link
Member Author

.deploy

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Deployment Triggered

GrantBirki, started a branch deployment 🚀

  • Branch: use-lang-with-api-queries
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to production July 7, 2022 17:35 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: use-lang-with-api-queries

Successfully deployed branch use-lang-with-api-queries

Actor: GrantBirki, Action: issue_comment, Workflow: branch-deploy

@GrantBirki GrantBirki merged commit 19786cc into main Jul 7, 2022
@GrantBirki GrantBirki deleted the use-lang-with-api-queries branch July 7, 2022 17:46
@Shebuka
Copy link
Contributor

Shebuka commented Jul 8, 2022

We have another problem, not only images are now in ru, but also the links... I'll suggest reverting this change until we have the API with trader ids
Screenshot 2022-07-08 at 10 46 39
Item page -> Trader portarait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request language Changes related to wording on the site or translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use selected language for API queries
3 participants