Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draupnir throws up full list of policy on !rules matching @username:matrix.example #707

Closed
JacksonChen666 opened this issue Jan 26, 2025 · 2 comments · Fixed by #715
Closed

Draupnir throws up full list of policy on !rules matching @username:matrix.example #707

JacksonChen666 opened this issue Jan 26, 2025 · 2 comments · Fixed by #715
Labels
2.0.0 Follow Up Issue discoverd in after the release of Draupnir 2.0.0 bug Something isn't working L3 Some Users Likelihood P2 Aggravating Priority level T3 Workflow Issue User employs strategies to achieve the task that harm the experience (use minor first).

Comments

@JacksonChen666
Copy link

How is Draupnir setup?

"Prefixless" (! only) enabled (ask for the rest later)

What were you trying to achieve?

Run !rules matching @username:matrix.example to see which room has a policy on a user being banned (well, more specifically, if the user was banned)

What steps did you take to encounter the bug

  1. I ran !rules matching @username:matrix.example (example username) in the management room.
  2. Draupnir threw up all policies (threaded) like I ran !rules (I didn't)

(This does not happen with a prefix or with a mention of draupnir)

What is the bug or what did you expect to happen instead?

Just return a shortened list where it says which rooms has a policy to ban the given user
@JacksonChen666 JacksonChen666 added the bug Something isn't working label Jan 26, 2025
@Gnuxie Gnuxie added L3 Some Users Likelihood P2 Aggravating Priority level T3 Workflow Issue User employs strategies to achieve the task that harm the experience (use minor first). 2.0.0 Follow Up Issue discoverd in after the release of Draupnir 2.0.0 labels Jan 26, 2025
@heftig
Copy link

heftig commented Jan 31, 2025

Similarly, !ban @user:home.server list reason is also broken, complaining it cannot parse the entity.

@Gnuxie
Copy link
Member

Gnuxie commented Jan 31, 2025 •
edited
Loading

@heftig Just a heads up if you are struggling you can still use !draupnir ban, this bug is specific to using commands without the !draupnir prefix. This is a priority for me to fix and will get looked at after I have finished with #704 & #691

Gnuxie added a commit to the-draupnir-project/interface-manager that referenced this issue Feb 2, 2025
@Gnuxie
Stop skipping arguments in command dispatcher's no prefix mode.
9043637 
the-draupnir-project/Draupnir#707
@Gnuxie Gnuxie mentioned this issue Feb 2, 2025
Merged
Gnuxie added a commit that referenced this issue Feb 2, 2025
@Gnuxie
Update to interface-manager v4.0.1 (#715)
81cb3e5 
- The signature of the `CommandDispatcher` `prefixExtractor` callback has been changed so that it is possible to transform the entire command body with a `commandNormaliser`.  This was changed primarily to fix #707.

Fixes #707.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0.0 Follow Up Issue discoverd in after the release of Draupnir 2.0.0 bug Something isn't working L3 Some Users Likelihood P2 Aggravating Priority level T3 Workflow Issue User employs strategies to achieve the task that harm the experience (use minor first).
Projects
Draupnir planning
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to interface-manager v4.0.1 the-draupnir-project/Draupnir
3 participants
@heftig @JacksonChen666 @Gnuxie