Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric to track number of chunk refetches #6593

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Aug 7, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

We have a counter metric for series refetch but don't have one for counter refetch.

Verification

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24
Copy link
Contributor Author

yeya24 commented Aug 8, 2023

Unit test failure is unrelated.

@GiedriusS GiedriusS merged commit 93cb319 into thanos-io:main Aug 9, 2023
@yeya24 yeya24 deleted the metrics-chunk-refetch branch August 23, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants