Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vector and scalar types in gRPC query range #6225

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

fpetkovski
Copy link
Contributor

@fpetkovski fpetkovski commented Mar 19, 2023

The gRPC query range method does not send back results when the result type is a vector or scalar. An example of a range query that returns a vector is absent(metric). A range query with the same start and end time also seems to return a vector instead of a matrix.

This commit adds support for those two response types.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Add support for vector and scalar return types in gRPC range query method.

Verification

Manual testing locally.

The gRPC query range method does not send back results when the
result type is a vector or scalar. An example of a range query that returns
a vector is absent(metric).

This commit adds support for those two response types.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
@fpetkovski fpetkovski force-pushed the grpc-range-query-response branch from 36d6e48 to 813240c Compare March 19, 2023 09:53
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 19, 2023
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fpetkovski fpetkovski merged commit 36de497 into thanos-io:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants