-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the old ui #4163
remove the old ui #4163
Conversation
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com> Co-authored-by: Prem Saraswat <prmsrswt@gmail.com>
34d83d5
to
56124ac
Compare
alright thanks to @onprem we managed to cleanup a bit more the code of the bucket UI. I believe a refactoring of the way to serve the UI should be done. I'm feeling we can simplify things but I think that should be done in another PR. This cleanup is already good :D. So anyway we should be good to merge now :). And let's for the refactoring later. |
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Oh no I mean if a refactoring should be performed to simplify the way to serve the UI, I believe it should be done first on Prometheus. This PR doesn't imply any refactoring, so we are good to merge. |
66674d9
to
e75fd51
Compare
Signed-off-by: Augustin Husson <augustin.husson@amadeus.com>
e75fd51
to
5a1ee84
Compare
@onprem I updated the PR regarding the last changes on the But until I found why my laptop doesn't want to run this command, could you (again) take a look at it and tell me if it should be ok to merge it once the |
or if you want, since I allowed edits by maintainer of this PR, you can run the command and push it to the PR. From my side, excepting the |
Be careful that the new UI has some big flaws: |
ah yeah the color issue can be a bit annoying indeed. If Thanos maintainer think it's a blocking issue and actually we should make some effort to fix it first on Prometheus side first ( the one you linked @roidelapluie and also others like prometheus/prometheus#6881), fine for me. It can make sense to be able to remove the UI first on Prometheus side and then here. It will just take much more time |
No worries, I'll take a look at the assets part. Also, I am in favor of delaying this PR a bit and try to get the issues mentioned by @roidelapluie fixed first. I agree that removing the old UI will remove a lot of friction on the development side, but I don't want to have that at the cost of user inconvenience. |
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
alright no problem :). I think I can decline this PR. We can reopen it or recreate it once it is the good time ^^. I don't see a good reason to keep it open |
we removed the old ui in Prometheus. So we can restart this one \o/ |
but probably you will want to get the perfomance improvement done in the Target, Alert and Service Discovery paged before removing it |
Signed-off-by: Augustin Husson husson.augustin@gmail.com
Changes
Verification
Manual testing by starting the binary locally with the query/ store mode