Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move retention at the start of the compactor loop #1735

Closed
wants to merge 1 commit into from
Closed

Move retention at the start of the compactor loop #1735

wants to merge 1 commit into from

Conversation

obiesmans
Copy link
Contributor

@obiesmans obiesmans commented Nov 8, 2019 •
edited
Loading

This PR tries to address issue #1708.
Feedback is welcome, especially on how to test those changes.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user

Changes

Verification

GiedriusS
GiedriusS requested changes Nov 8, 2019
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! One small language error + missing CHANGELOG.md item for this and I think this is good. (:

@GiedriusS GiedriusS changed the title WIP : Move retention at the start of the compactor loop. Move retention at the start of the compactor loop Nov 8, 2019
@GiedriusS GiedriusS requested a review from bwplotka November 8, 2019 20:55
Move retention at the start of the compactor loop.
f952aa0 
Signed-off-by: Olivier Biesmans <olivier.biesmans@blablacar.com>
@obiesmans obiesmans force-pushed the retention-before-compaction branch from 53eefdf to f952aa0 Compare November 14, 2019 09:57
bwplotka
bwplotka requested changes Nov 14, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need more complex logic here, sorry we missed that in the initial issue description.

See this: #1708 (comment)

@obiesmans
Copy link
Contributor Author

Ahah, didn't think that the compactor would potentially not run for an undetermined amount of time. Nice catch @bwplotka. I'm correcting the PR.

@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 11, 2020
@stale stale bot closed this Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS requested changes

@bwplotka bwplotka bwplotka requested changes

Assignees
No one assigned
Labels
component: compact stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obiesmans @GiedriusS @bwplotka