Skip to content

Commit

Permalink
Query: dynamic endpointgroups are allowed
Browse files Browse the repository at this point in the history
This PR fixes a bug where dynamic endpoint groups are silently ignored.

Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
  • Loading branch information
Michael Hoffmann committed Feb 19, 2025
1 parent 71bbafb commit 632b7f3
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions cmd/thanos/endpointset.go
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,6 @@ func setupEndpointSet(
specs := make([]*query.GRPCEndpointSpec, 0)
for _, ecfg := range endpointConfig.Endpoints {
strict, group, addr := ecfg.Strict, ecfg.Group, ecfg.Address
if dns.IsDynamicNode(addr) {
continue
}
if group {
specs = append(specs, query.NewGRPCEndpointSpec(fmt.Sprintf("thanos:///%s", addr), strict, append(dialOpts, extgrpc.EndpointGroupGRPCOpts()...)...))
} else {
Expand Down

0 comments on commit 632b7f3

Please sign in to comment.