-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes http_request options in dm defines #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming you've tested this, LGTM
Cyberboss
pushed a commit
to tgstation/tgstation
that referenced
this pull request
Jan 16, 2021
Allows embedding icon edits in your maps by fetching them from external host. This is intended for use with live-loaded away/event maps not standard ones. Also updates rustg defines to expose the additional options arguments. (tgstation/rust-g#59)
drexample
pushed a commit
to SS13-Aeon/Nightstation-13
that referenced
this pull request
Jan 16, 2021
Allows embedding icon edits in your maps by fetching them from external host. This is intended for use with live-loaded away/event maps not standard ones. Also updates rustg defines to expose the additional options arguments. (tgstation/rust-g#59)
SkyratBot
pushed a commit
to Skyrat-SS13/Skyrat-tg
that referenced
this pull request
Jan 16, 2021
Allows embedding icon edits in your maps by fetching them from external host. This is intended for use with live-loaded away/event maps not standard ones. Also updates rustg defines to expose the additional options arguments. (tgstation/rust-g#59)
Azarak
pushed a commit
to Skyrat-SS13/Skyrat-tg
that referenced
this pull request
Jan 17, 2021
* Adds custom icon mapping helper. (#56183) Allows embedding icon edits in your maps by fetching them from external host. This is intended for use with live-loaded away/event maps not standard ones. Also updates rustg defines to expose the additional options arguments. (tgstation/rust-g#59) * Adds custom icon mapping helper. Co-authored-by: AnturK <AnturK@users.noreply.github.com>
SpaceManiac
approved these changes
Jan 21, 2021
MarkSuckerberg
pushed a commit
to MarkSuckerberg/WaspStation-1.0
that referenced
this pull request
Apr 26, 2021
Allows embedding icon edits in your maps by fetching them from external host. This is intended for use with live-loaded away/event maps not standard ones. Also updates rustg defines to expose the additional options arguments. (tgstation/rust-g#59)
MarkSuckerberg
pushed a commit
to MarkSuckerberg/WaspStation-1.0
that referenced
this pull request
Apr 26, 2021
Allows embedding icon edits in your maps by fetching them from external host. This is intended for use with live-loaded away/event maps not standard ones. Also updates rustg defines to expose the additional options arguments. (tgstation/rust-g#59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tgstation/tgstation#56183