-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenAPI 3.1 #378
Comments
hi @BorisBeast, the plan is definitely there. imho swagger-api/swagger-ui/issues/5891 OpenAPITools/openapi-generator/issues/9083 in any case, some of the new feature may take a while to implement as the move to JSON schema in the new specification has quite a few smaller and bigger implications. |
small update:
With all the changes in OpenAPI 3.1, I currently only see a potential issue with the change in semantics for That said, I decided to wait a little longer with adoption. Firstly, drf-spectacular is not very useful without a working ecosystem around it. Secondly, we do not simply implement OpenAPI without any context. We intentionally refrain from using certain valid constructions, which have shown to create problems with other tools. Not every valid schema will be properly handled by UIs or code generators. That practical aspect is very important to drf-spectacular and it's probably best to wait a bit longer until the dust has settled in the ecosystem. |
I'm excited for OpenAPI 3.1 but I too think it is pragmatic to wait a while for the rest of the ecosystem to catch up. |
Hello @johnthagen I am getting this error, any idea how to fix this? so far my understanding its required OpenAPI 3.0. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@pranto157 this issue is dedicated to OpenAPI 3.1. your issue is unrelated. |
Hello all , @tfranzel did you add the support for OpenAPI 3.1? |
we released 0.27.0, which is the first version to support 3.1 I'm not exactly sure how to answer your second question @Fares-Abubaker. 3.1 was made to be JSON Schema compatible. So by definition if a schema is OpenAPI 3.1, it has to be JSON Schema compatible. The differences are small anyway and we only adapted what was conflicting with conformity. Is there anything missing? I'll close this issue as I consider this resolved. If anything else is missing, please feel free to open a new issue. |
We released 0.27.0 with basic OpenAPI 3.1 support. For further feature requests regarding 3.1 features, please open a new issue. |
Thanks @tfranzel for the hard work. I'm playing around with the new OpenAPI 3.1 swagger from the latest release (
What am I missing here? |
The error msg implicitly states that 3.1 is not supported, only 2 and 3.0.x.
The next version of swagger UI, does support it though, as can be seen on
their editor example page. I believe this version is still beta and thus
not part of the sidecar at the moment.
You would need to find a cdn link with the proper version to make this work
…On Wed, Apr 17, 2024, 10:48 tu-pm ***@***.***> wrote:
Thanks @tfranzel <https://github.com/tfranzel> for the hard work.
I'm playing around with the new OpenAPI 3.1 swagger from the latest
release (drf-spectacular==0.27.2 and drf-spectacular-sidecar==2024.4.1)
by setting 'OAS_VERSION': '3.1.0', in SPECTACULAR_SETTINGS and the
Swagger UI page still displays this message:
Unable to render this definition
The provided definition does not specify a valid version field.
Please indicate a valid Swagger or OpenAPI version field. Supported version fields are swagger: "2.0" and those that match openapi: 3.0.n (for example, openapi: 3.0.0).
What am I missing here?
—
Reply to this email directly, view it on GitHub
<#378 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADHB2EPCR6ZU2NNUUEJMYR3Y5YZM3AVCNFSM44JJVRM2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBWGA3TGMZSGE3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Are there any plans to support OpenAPI v3.1? If yes when can we expect it?
If nothing else it will allow exploded arrays for multipart/form-data requests which is the default behavior of MultipartParser.
https://spec.openapis.org/oas/v3.1.0#fixed-fields-12
The text was updated successfully, but these errors were encountered: