Use native abort controller when possible #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
andrewxhill
reviewed
Aug 26, 2021
| @@ -1,4 +1,4 @@ | |||
| export { AbortController, AbortSignal } from 'abort-controller' | |||
| export { AbortController, AbortSignal } from 'native-abort-controller' | |||
There was a problem hiding this comment.
maybe worth an inline comment about mysticatea/abort-controller#24 and deprecating this need?
There was a problem hiding this comment.
I might be misunderstanding your statement, of those in that issue... but this switch is the fix required to support native AbortController when available... no?
There was a problem hiding this comment.
Ah I see, you are referring to the fact that if abort-controller supports this, we can switch back... yes good idea.
There was a problem hiding this comment.
until that issue is resolved, at which point the switch is no longer needed
andrewxhill
approved these changes
Aug 26, 2021
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #819