Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: pass runtimeValueLocationStack by values to reduce allocations #1170

Merged
merged 1 commit into from
Feb 27, 2023
Merged

compiler: pass runtimeValueLocationStack by values to reduce allocations #1170

merged 1 commit into from
Feb 27, 2023

Conversation

mathetake
Copy link
Member 

name         old time/op    new time/op    delta
_compile-10     870ms ± 0%     863ms ± 1%  -0.79%  (p=0.000 n=18+20)

name         old alloc/op   new alloc/op   delta
_compile-10     589MB ± 0%     565MB ± 0%  -4.03%  (p=0.000 n=20+19)

name         old allocs/op  new allocs/op  delta
_compile-10     7.22M ± 0%     6.69M ± 0%  -7.24%  (p=0.000 n=20+19)

@mathetake
compiler: pass runtimeValueLocationStack by values to reduce allocations
9d100fc 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake marked this pull request as ready for review February 27, 2023 00:26
@mathetake mathetake merged commit 5eab1a7 into main Feb 27, 2023
@mathetake mathetake deleted the locationstack branch February 27, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @codefromthecrypt