wasi/platform: supports inode and dev on Windows #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
b9bdbaa to
694ed10
Compare
Signed-off-by: Adrian Cole <adrian@tetrate.io>
|
great milestone on windows, @mathetake! p.s. I think we're nearing or at feature coverage needed to start looking at our own file type, which can really help us pay down the accruing platform-specific tech debt, or at least organize it :p |
|
yep, I think now we've revealed all the requirements that our file type should have now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes wazero pass all wasi-testsuits on Windows: https://github.com/tetratelabs/wazero/actions/runs/4190204141/jobs/7263376402
I will raise another PR to enable the CI job of testsuite on Windows to close .#1036 officially.