Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform: adjusts errno on dangling symlink on Windows #1130

Merged
merged 3 commits into from
Feb 16, 2023
Merged

platform: adjusts errno on dangling symlink on Windows #1130

merged 3 commits into from
Feb 16, 2023

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Feb 16, 2023 •
edited
Loading

part of #1036

@mathetake
platform: adjusts errno on dangling symlink on Windows
81574a1 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Copy link
Member Author

🤞

@mathetake
lint
ccb3188 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
fix
c5476f1 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
Copy link
Member Author

OK now the only test fails is inode related https://github.com/tetratelabs/wazero/actions/runs/4189804425/jobs/7262549820

@mathetake mathetake marked this pull request as ready for review February 16, 2023 01:45
codefromthecrypt
codefromthecrypt approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the deep digging, especially on windows!

@mathetake mathetake merged commit e54e0c7 into main Feb 16, 2023
@mathetake mathetake deleted the dangling branch February 16, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @codefromthecrypt