Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi: returns ELOOP properly #1104

Merged
merged 1 commit into from
Feb 7, 2023
Merged

wasi: returns ELOOP properly #1104

merged 1 commit into from
Feb 7, 2023

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Feb 7, 2023

Closes .#1036 modulo windows

Signed-off-by: Takeshi Yoneda takeshi@tetrate.io

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake marked this pull request as ready for review February 7, 2023 04:01
@@ -311,5 +311,3 @@ jobs:
./tests/rust/testsuite/ \
-f ./tests/rust/skip.json \
-r ./adapters/wazero.sh
# TODO: remove when #1036 is complete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait. this is it then?!

Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow great and just in time for gophercon it seems!

@mathetake mathetake merged commit 9dbed75 into main Feb 7, 2023
@mathetake mathetake deleted the eloop branch February 7, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants