Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: implements fd_renumber #1095

Merged
merged 3 commits into from
Feb 3, 2023
Merged

wasi: implements fd_renumber #1095

merged 3 commits into from
Feb 3, 2023

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Feb 3, 2023 •
edited
Loading

part of #1036

Signed-off-by: Takeshi Yoneda takeshi@tetrate.io

@mathetake
wasi: implements fd_renumber
18c5fe8 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
unit test
8664355 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake
unit test
65e24fb 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake marked this pull request as ready for review February 3, 2023 01:17
@mathetake
Copy link
Member Author

now 4 tests left in wasi-testsuit

Tests: 4 failed, 30 passed, 0 total

codefromthecrypt
codefromthecrypt approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress and it was very empathetic of you to leave those notes about the ambiguity!

@mathetake mathetake merged commit f719b49 into main Feb 3, 2023
@mathetake mathetake deleted the implementsrenumber branch February 3, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @codefromthecrypt