-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha: add wasi-testsuite #1062
gha: add wasi-testsuite #1062
Conversation
.github/workflows/integration.yaml
Outdated
|
||
wasi-testsuite: | ||
name: wasi-testsuite | ||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's run mac and windows as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that runs-on: ${{ matrix.os }}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
64311b5
to
26b117a
Compare
@@ -167,3 +167,43 @@ jobs: | |||
unicode \ | |||
unicode/utf16 \ | |||
unicode/utf8 | |||
|
|||
|
|||
wasi-testsuite: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to install the python dependencies via pip install -r requirements/dev.txt
and please configure the proper caching for them`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be ok now
26b117a
to
d859023
Compare
I think I managed to run the scripts on Windows as well, but it was not trivial. The "fix" I tried is to set an env variable to make sure the runners are able to find It looks like some tests are not passing but it is likely to be the |
d859023
to
f6d895e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ps when we get to windows, echo "EXTRA_ENV_VAR=value" >> $GITHUB_ENV
in a conditional step will be better than repeating the latter.
.github/workflows/integration.yaml
Outdated
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
os: [ubuntu-20.04, macos-12, windows-2022] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch windows-2022 to a TODO comment
.github/workflows/integration.yaml
Outdated
- name: Initialize Python environment | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: '3.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment if this can be any version of python (e.g. . # latest version of python 3
if it isn't specific)
f6d895e
to
a125191
Compare
yeah but will that work on Windows? |
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
a125191
to
851523b
Compare
actually I wonder if this would have worked on windows vs setting that ENV variable. In func-e we force bash for consistency https://github.com/tetratelabs/func-e/blob/master/.github/workflows/packaging.yaml#L34 |
Thanks for this! |
Unfortunately no I tried that. Apparently the "right" bash is not on the PATH. An alternative fix may be to fiddle with PATH too but I wonder how much pain it is to do it in GHA, on Windows, x-platform. I tried to figure it out and it looked complicated |
Thanks for trying! In any case if we default to bash we can use the append syntax to add special variables, even if we yeah still need to add those. e.g. |
or we can use normal template variables. In any case, setting variables is the easier part. |
Checkout
wasi-testsuite
fromtetratelabs/wasi-testsuite@wazero
branch then launch the tests using the wazero adapter.It looks fast enough it could run at each PR.
-mount
syntax (Windows paths may contain:
) . I disabled it for now.Signed-off-by: Edoardo Vacchi evacchi@users.noreply.github.com