-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
path_open
with an empty path should fail
#2222
Labels
bug
Something isn't working
Comments
yagehu
added a commit
to yagehu/wazero
that referenced
this issue
May 28, 2024
This commit makes `path_open` return `inval` when passed an empty path. This behavior is consistent with other Wasm runtimes (Wasmtime, Wasmer, Node, WAMR, WasmEdge). fixes tetratelabs#2222
yagehu
added a commit
to yagehu/wazero
that referenced
this issue
May 28, 2024
This commit makes `path_open` return `inval` when passed an empty path. This behavior is consistent with other Wasm runtimes (Wasmtime, Wasmer, Node, WAMR, WasmEdge). fixes tetratelabs#2222 Signed-off-by: Yage Hu <me@huyage.dev>
yagehu
added a commit
to yagehu/wazero
that referenced
this issue
May 28, 2024
This commit makes `path_open` return `inval` when passed an empty path. This behavior is consistent with other Wasm runtimes (Wasmtime, Wasmer, Node, WAMR, WasmEdge). fixes tetratelabs#2222 Signed-off-by: Yage Hu <me@huyage.dev>
yagehu
added a commit
to yagehu/wazero
that referenced
this issue
May 28, 2024
This commit makes `path_open` return `inval` when passed an empty path. This behavior is consistent with other Wasm runtimes (Wasmtime, Wasmer, Node, WAMR, WasmEdge). fixes tetratelabs#2222 Signed-off-by: Yage Hu <me@huyage.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Calling
path_open
on an empty path fails on host Linux as well as other runtimes (Wasmtime, Node, WAMR, WasmEdge, Wasmer). But Wazero succeeds and returns a fd.As a reference, POSIX specifies that:
A rust example that uses
wasi
crate0.11
.Expected behavior
Wazero should error and not return a fd.
Environment (please complete the relevant information):
The text was updated successfully, but these errors were encountered: