Parameters of nested test suites are overriden

[chillinPanda]

Github Demo Project with bug

I wrote a little demo project to show you this problem and that you can play and interact with it. There are also more information on the readme.md.
Check out https://github.com/chillinPanda/testng-parameter-error

Problem

If I nest two test suites into one and use parameter in the nested suite-file definition, those are overriden by following same-name-parameters. In the following example "www.wikipedia.org" will be overriden to "www.google.com" and then the tests at src/test/testng_xmls/testng_wiki.xml get a wrong parameter (the one from below)

<suite name="Demo" parallel="tests">
  <suite-files>

    <suite-file path="src/test/testng_xmls/testng_wiki.xml">
      <parameter name="url" value="www.wikipedia.org" />
    </suite-file>

    <suite-file path="src/test/testng_xmls/testng_google.xml">
      <parameter name="url" value="www.google.com" />
    </suite-file>

  </suite-files>
</suite>

[chillinPanda]

I am looking through the testng source and perhaps this is the problem:

Class: XmlSuite.java

this is in the git repo:

  /**
   * @return The parameters defined in this suite and all its XmlTests.
   */
  public Map<String, String> getAllParameters() {
    Map<String, String> result = Maps.newHashMap();
    for (Map.Entry<String, String> entry : m_parameters.entrySet()) {
      result.put(entry.getKey(), entry.getValue());
    }

    for (XmlTest test : getTests()) {
      Map<String, String> tp = test.getLocalParameters();
      for (Map.Entry<String, String> entry : tp.entrySet()) {
        result.put(entry.getKey(), entry.getValue());
      }
    }

    return result;
  }

I did not have the time to test it. But perhaps something like this would resolve the problem:

  /**
   * @return The parameters defined in this suite and all its XmlTests.
   */
  public Map<String, String> getAllParameters() {
    Map<String, String> result = Maps.newHashMap();
    for (Map.Entry<String, String> entry : m_parameters.entrySet()) {
      result.put(entry.getKey(), entry.getValue());
    }

    for (XmlTest test : getTests()) {
      Map<String, String> tp = test.getLocalParameters();
      for (Map.Entry<String, String> entry : tp.entrySet()) {

        // check if key already exists and use priority. local test keys are more important
        if (result.containsKey(entry.getKey())) {
          // assumption for next if statement: this determines that the currently running test is the test we iterate through and test names are distinct.
          if (test.getName().equals(getTest())) { 
            result.put(entry.getKey(), entry.getValue());
          }
        }

      }
    }

    return result;
  }

[krmahadevan]

<parameter> is not supposed to be passed from within the <suite-file>. But there's a parsing bug in TestNG owing to which TestNG ends up reading the parameter (which it should never have).

That has been fixed as part of this PR #2923

[krmahadevan]

Also we have tightened the dtd file via testng-team/testng-team.github.io#46 and released a new version of it at http://testng.org/testng-1.1.dtd

We have also enriched the codebase to now refer to the tighthened DTD testng-1.1.dtd as an embedded DTD within the TestNG codebase as part of the PR #2923