Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: identify browser/jsdom differences #1091

Merged
merged 17 commits into from
Jan 12, 2025
Merged

test: identify browser/jsdom differences #1091

merged 17 commits into from
Jan 12, 2025

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented Dec 27, 2022

What:

Identify the differences between Chrome and Jsdom environment.

Why:

Determine if failing tests in Chrome are the result of wrong assumptions in our tests or wrong implementations in our source.

Checklist:

  • Ready to be merged

Findings:

Some of our tests rely on Jsdom-specific behavior and in at least one case the browser implementation has changed.
I've added TODOs (either in test or source) where i could identify the cause of different results in the test environments.

Any new discoveries of differences between Jsdom and Chrome should be added to tests/environment so that we can easily keep track of the quirks.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 27, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #1091 (2463be9) into main (7a305de) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1091   +/-   ##
=======================================
  Coverage   99.46%   99.47%           
=======================================
  Files          92       92           
  Lines        2070     2085   +15     
  Branches      714      706    -8     
=======================================
+ Hits         2059     2074   +15     
  Misses         11       11           
Impacted Files Coverage Δ
src/system/keyboard.ts 100.00% <100.00%> (ø)
src/system/pointer/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ph-fritsche ph-fritsche marked this pull request as ready for review January 12, 2025 17:40
@ph-fritsche ph-fritsche merged commit 139d18f into main Jan 12, 2025
3 checks passed
@ph-fritsche ph-fritsche deleted the test branch January 12, 2025 18:07
Copy link

🎉 This PR is included in version 14.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant