src/client: Implement init proceedure #25
Conversation
| @@ -133,7 +154,7 @@ impl Client { | |||
|
|
|||
| /// ```wait_network_initialized``` waits for the sidecar to initialize the network, | |||
| /// if the sidecar is enabled. | |||
| pub async fn wait_network_initialized(&self) -> Result<(), Error> { | |||
| async fn wait_network_initialized(&self) -> Result<(), Error> { | |||
There was a problem hiding this comment.
I can not think of a use-case where one would not call this method at start. Thus I am proposing to include it in new_and_init (see above) and making the method itself private.
There was a problem hiding this comment.
Can't think of a case either! 👍
Before running a test case, the sdk-go does: - Waits for the network sidecar to initialize the network. - Signals *being initialized* to the global count. - Signals *being initialized* to the group count. - Records the global sequence number and the group sequence number as a message. With this commit the sdk-rust follows the same steps. In addition it not only signals but also waits for all instances and the instances in the group to *being initialized*.
| global_seq_num, params.test_group_id, group_seq_num | ||
| )); | ||
|
|
||
| Ok((client, params)) | ||
| } |
There was a problem hiding this comment.
Looks good, thanks for sharing the draft!
A couple of notes:
- the go sdk doesn't wait in the init, but provides methods to do so
- I can't see a good reason to need this level of granularity, I guess we'll port this behavior to the go-sdk
- the go sdk sends the global seq and group seq to the test
- It might be useful to implement leader/follower quickly. Related discussion
- I've seen it used in another test as seed value, but that use case seems anecdotal
There was a problem hiding this comment.
the go sdk sends the global seq and group seq to the test
👍 for exposing it to the test, though I haven't clean way to do so yet. Still want to put more thoughts into it. In my eyes this can happen as a follow up.
There was a problem hiding this comment.
- I can't see a good reason to need this level of granularity, I guess we'll port this behavior to the go-sdk
Same here. I can't think of a use-case where one would want to publish but not wait.
|
For the record, also tested with https://github.com/testground/testground/tree/master/plans/example-rust. |
Fixes #15.
Before running a test case, the sdk-go does:
https://github.com/testground/sdk-go/blob/49c90fa754052018b70c63d87b7f1d37f6080a78/run/init_context.go#L43-L65
With this commit the sdk-rust follows the same steps. In addition it not only
signals but also waits for all instances and the instances in the group to
being initialized.
Opening as draft for now due to small TODOs left. Already interested in what you think @laurentsenta @ackintosh @SionoiS.