Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(orientdb): use rest-api instead of client library #80

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

mervyn-mccreight
Copy link
Contributor

The client library seems not well maintained and contains pretty outdated dependencies. For testing purposes using the REST-API works well enough.

retry is used to stabilise the test, since at least locally it took the container some time after start-up to accept REST-API requests sometimes. I couldn't find out a way to wait exactly for the time when the API is ready. According to the container logs the start-up is finished.

Closes #38

@mervyn-mccreight mervyn-mccreight marked this pull request as ready for review January 3, 2024 16:53
Copy link
Contributor

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM

@DDtKey DDtKey merged commit 3dc3c3d into main Jan 3, 2024
7 checks passed
@mervyn-mccreight mervyn-mccreight deleted the refactor/remove-orient-db-client branch January 3, 2024 17:05
@github-actions github-actions bot mentioned this pull request Jan 3, 2024
DDtKey pushed a commit that referenced this pull request Jan 3, 2024
## 🤖 New release
* `testcontainers-modules`: 0.2.1 -> 0.3.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.3.0] - 2024-01-03

### Bug Fixes

- [**breaking**] Disable host auth method by default
([#81](#81))

### Refactor

- Use rest-api instead of client library
([#80](#80))

<!-- generated by git-cliff -->
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of orientdb-client
2 participants