Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Valkey module #252

Merged
merged 5 commits into from
Jan 7, 2025
Merged

feat: add Valkey module #252

merged 5 commits into from
Jan 7, 2025

Conversation

ivanvs
Copy link
Contributor

@ivanvs ivanvs commented Dec 14, 2024

No description provided.

@DDtKey DDtKey changed the title feat: Add Valkey module feat: add Valkey module Dec 16, 2024
Copy link
Contributor

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 🙏

@DDtKey
Copy link
Contributor

DDtKey commented Dec 16, 2024

Could you apply ruasfmt formatting?

@ivanvs
Copy link
Contributor Author

ivanvs commented Dec 16, 2024

Yes, sure.

I am still learning rust tooling...

Copy link
Contributor

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires to run cargo +nightly fmt. I've applied it

src/valkey/mod.rs Outdated Show resolved Hide resolved
src/valkey/mod.rs Outdated Show resolved Hide resolved
src/valkey/mod.rs Outdated Show resolved Hide resolved
@DDtKey DDtKey changed the title feat: add Valkey module feat: add Valkey module Jan 7, 2025
@DDtKey DDtKey merged commit b5c8b61 into testcontainers:main Jan 7, 2025
6 checks passed
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
DDtKey pushed a commit that referenced this pull request Jan 7, 2025
## 🤖 New release
* `testcontainers-modules`: 0.11.4 -> 0.11.5 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.11.5] - 2025-01-07

### Bug Fixes

- Fix clippy errors (#251)

### Documentation

- Add nats example (#239)

### Features

- Add "pro" variant for LocalStack image (#255)
- Add `Valkey` module (#252)
- Add `RQLite` module (#261)

### Miscellaneous Tasks

- Update async-nats requirement from 0.37.0 to 0.38.0 (#245)
- Fix oracle tests (#263)
- Bump MSRV to `1.81` (#264)
- Utilize cargo-hack partitions to speed up tests (#265)

<!-- generated by git-cliff -->
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants