feat: implement with_init_sql for Postgres, Mysql and Mariadb
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDtKey
reviewed
Aug 20, 2024
|
Thank you for the contribution! ❤️ |
|
Now it's possible with image.with_copy_to(
"/docker-entrypoint-initdb.d/init.sql",
include_bytes!("initdb.sql").to_vec(),
)Which I found simple enough. |
|
Yea that definitely cleans things up a ton. Thanks 🙏 => This PR might take a few weeks before I can actually invest the time it deserves |
3204048 to
1b443b2
Compare
Postgres::with_init_sqlSelf::with_init_sql
CommanderStorm
commented
Sep 25, 2024
9565042 to
c8cb10a
Compare
b23effe to
506c529
Compare
CommanderStorm
commented
Sep 25, 2024
Self::with_init_sqlSelf::with_init_sql
Self::with_init_sqlSelf::with_init_sql for postgres, mysql and mariadb
Self::with_init_sql for postgres, mysql and mariadbPostgres::with_init_sql, Mysql::with_init_sql and and Mariadb::with_init_sql`
Postgres::with_init_sql, Mysql::with_init_sql and and Mariadb::with_init_sql`Postgres::with_init_sql, Mysql::with_init_sql and Mariadb::with_init_sql
Postgres::with_init_sql, Mysql::with_init_sql and Mariadb::with_init_sqlwith_init_sql for Postgres, Mysql and Mariadb
DDtKey
approved these changes
Sep 25, 2024
DDtKey
approved these changes
Sep 26, 2024
Merged
DDtKey
pushed a commit
that referenced
this pull request
Sep 26, 2024
## 🤖 New release * `testcontainers-modules`: 0.11.0 -> 0.11.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.11.1] - 2024-09-26 ### Documentation - Disallow missing docs on crate level and allow where necessary ([#222](#222)) ### Features - Implement `with_init_sql` for `Postgres`, `Mysql` and `Mariadb` ([#182](#182)) - Tls certs and ldif file ([#217](#217)) <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #164
The implementation is a bit hacky, am open to better approaches or other feedback ^^The implementation is pretty straigtforeward and similar to #217