Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to reusable containers #6216

Merged
merged 12 commits into from
Nov 17, 2022
Merged

Add documentation to reusable containers #6216

merged 12 commits into from
Nov 17, 2022

Conversation

eddumelendez
Copy link
Member

Reusable containers is an experimental features and docs should
address questions around what is it? and how to enable it?

Reusable containers is an experimental features and docs should
address questions around `what is it?` and `how to enable it?`
@eddumelendez eddumelendez requested a review from a team as a code owner November 16, 2022 19:33
docs/features/reuse.md Outdated Show resolved Hide resolved
docs/features/reuse.md Outdated Show resolved Hide resolved
docs/features/reuse.md Outdated Show resolved Hide resolved
docs/features/reuse.md Outdated Show resolved Hide resolved
eddumelendez and others added 3 commits November 16, 2022 16:51
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
@eddumelendez eddumelendez added this to the next milestone Nov 17, 2022
docs/features/reuse.md Outdated Show resolved Hide resolved
docs/features/reuse.md Outdated Show resolved Hide resolved
docs/features/reuse.md Outdated Show resolved Hide resolved
eddumelendez and others added 2 commits November 16, 2022 17:17
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
kiview
kiview previously approved these changes Nov 17, 2022
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions, happy to finally include in in our docs 🙂

* Define container with `withReuse(true)`

```java
GenericContainer container = new GenericContainer("redis:6-alpine")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we have a code include, but I think for such a small snippet, it is fine 😉

docs/features/reuse.md Outdated Show resolved Hide resolved
docs/features/reuse.md Outdated Show resolved Hide resolved
docs/features/reuse.md Outdated Show resolved Hide resolved
docs/features/reuse.md Outdated Show resolved Hide resolved
docs/features/reuse.md Outdated Show resolved Hide resolved
docs/features/reuse.md Outdated Show resolved Hide resolved
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
eddumelendez and others added 5 commits November 17, 2022 05:49
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants