MySQL liveness check port numbers were missing

testcontainers · Aug 18, 2022 · 4612773 · 4612773
1 parent 4b68ef3
commit 4612773
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/modules/mysql/src/main/java/org/testcontainers/containers/MySQLContainer.java b/modules/mysql/src/main/java/org/testcontainers/containers/MySQLContainer.java
@@ -4,6 +4,7 @@
 import org.testcontainers.utility.DockerImageName;
 
 import java.util.HashSet;
+import java.util.List;
 import java.util.Set;
 
 /**
@@ -56,12 +57,6 @@ public MySQLContainer(final DockerImageName dockerImageName) {
         addExposedPort(MYSQL_PORT);
     }
 
-    @NotNull
-    @Override
-    protected Set<Integer> getLivenessCheckPorts() {
-        return new HashSet<>(getMappedPort(MYSQL_PORT));
-    }
-
     @Override
     protected void configure() {
         optionallyMapResourceParameterAsVolume(

diff --git a/modules/mysql/src/test/java/org/testcontainers/junit/mysql/SimpleMySQLTest.java b/modules/mysql/src/test/java/org/testcontainers/junit/mysql/SimpleMySQLTest.java
@@ -237,4 +237,16 @@ public void testWithAdditionalUrlParamInJdbcUrl() {
             mysql.stop();
         }
     }
+
+    @Test
+    public void testExposedAndLivenessCheckPorts() {
+        try (
+            MySQLContainer<?> mysql = new MySQLContainer<>(MySQLTestImages.MYSQL_57_IMAGE)
+                .withLogConsumer(new Slf4jLogConsumer(logger));
+        ) {
+            mysql.start();
+            assertThat(mysql.getExposedPorts()).containsExactly(MySQLContainer.MYSQL_PORT);
+            assertThat(mysql.getLivenessCheckPortNumbers()).containsExactly(mysql.getMappedPort(MySQLContainer.MYSQL_PORT));
+        }
+    }
 }