-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add example of using Pulsar with testcontainers-go #597
Conversation
This is super cool!! Thanks for adding the example. I'd remove the gomega dependency to avoid associating the example with a test framework. I'd use testing library + require or assert. You can check the ones used in the project as a reference. In any case, this LGTM!! |
I've just realized that the example is not shown in the website because the mkdocs descriptor living in the root for of the project, she's not included the new entry. Could you please add it? |
done 👍 ... just saw that I had the log-following code still in there ... do you think we should leave that in the example, or should I remove that so it's just showing Pulsar usage? |
done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
I've test it locally with success, thanks for this great example on Apache Pulsar usage. Great job
A quick example of how I used Pulsar in a recent test for another project which others might find useful.
It essentially mimics the way the testcontainers-java Pulsar module sets up Pulsar.